refactor(imageproxy): reduce noisy image cache logging (#2789)

server/lib/imageproxy.ts

@@ -55,16 +55,12 @@ class ImageProxy {
       }
     } catch (e) {
       if (e.code === 'ENOENT') {
-        logger.error('Directory not found', {
+        return;
-          label: 'Image Cache',
-          message: e.message,
-        });
-      } else {
-        logger.error('Failed to read directory', {
-          label: 'Image Cache',
-          message: e.message,
-        });
       }
+      logger.error('Failed to read directory', {
+        label: 'Image Cache',
+        message: e.message,
+      });
     }
 
     logger.info(`Cleared ${deletedImages} stale image(s) from cache '${key}'`, {

server/routes/avatarproxy.ts

@@ -141,13 +141,16 @@ router.get('/:jellyfinUserId', async (req, res) => {
 
     const jellyfinAvatarUrl = getJellyfinAvatarUrl(req.params.jellyfinUserId);
 
-    let imageData = await avatarImageCache.getImage(
+    let imageData;
-      jellyfinAvatarUrl,
+    if (user?.avatarVersion) {
-      fallbackUrl
+      imageData = await avatarImageCache.getImage(
-    );
+        jellyfinAvatarUrl,
-
+        fallbackUrl
-    if (imageData.meta.extension === 'json') {
+      );
-      // this is a 404
+      if (imageData.meta.extension === 'json') {
+        imageData = await avatarImageCache.getImage(fallbackUrl);
+      }
+    } else {
       imageData = await avatarImageCache.getImage(fallbackUrl);
     }