fix(setup): plex library setting validation (#1233)

* fix(setup): plex library setting validation

* fix(setup): fixes plex continue button and scroll-to-top when clicked issue in setup

src/components/Settings/SettingsPlex.tsx

@@ -350,6 +350,10 @@ const SettingsPlex = ({ onComplete }: SettingsPlexProps) => {
       );
       if (!res.ok) throw new Error();
     }
+
+    if (onComplete) {
+      onComplete();
+    }
     setIsSyncing(false);
     revalidate();
   };
@@ -435,10 +439,6 @@ const SettingsPlex = ({ onComplete }: SettingsPlexProps) => {
               autoDismiss: true,
               appearance: 'success',
             });
-
-            if (onComplete) {
-              onComplete();
-            }
           } catch (e) {
             if (toastId) {
               removeToast(toastId);

src/components/Setup/index.tsx

@@ -97,18 +97,36 @@ const Setup = () => {
       settings.currentSettings.mediaServerType !==
       MediaServerType.NOT_CONFIGURED
     ) {
-      setCurrentStep(3);
       setMediaServerType(settings.currentSettings.mediaServerType);
+      if (currentStep < 3) {
+        setCurrentStep(3);
+      }
     }
 
     if (currentStep === 3) {
+      validateLibraries();
+    }
+  }, [
+    settings.currentSettings.mediaServerType,
+    settings.currentSettings.initialized,
+    router,
+    toasts,
+    intl,
+    currentStep,
+    mediaServerType,
+  ]);
+
   const validateLibraries = async () => {
     try {
-          const endpoint =
+      const endpointMap: Record<MediaServerType, string> = {
-            settings.currentSettings.mediaServerType ===
+        [MediaServerType.JELLYFIN]: '/api/v1/settings/jellyfin',
-              MediaServerType.JELLYFIN || MediaServerType.EMBY
+        [MediaServerType.EMBY]: '/api/v1/settings/jellyfin',
-              ? '/api/v1/settings/jellyfin'
+        [MediaServerType.PLEX]: '/api/v1/settings/plex',
-              : '/api/v1/settings/plex';
+        [MediaServerType.NOT_CONFIGURED]: '',
+      };
+
+      const endpoint = endpointMap[mediaServerType];
+      if (!endpoint) return;
 
       const res = await fetch(endpoint);
       if (!res.ok) throw new Error('Fetch failed');
@@ -119,11 +137,6 @@ const Setup = () => {
       );
 
       setMediaServerSettingsComplete(hasEnabledLibraries);
-          if (hasEnabledLibraries) {
-            localStorage.setItem('mediaServerSettingsComplete', 'true');
-          } else {
-            localStorage.removeItem('mediaServerSettingsComplete');
-          }
     } catch (e) {
       toasts.addToast(intl.formatMessage(messages.librarieserror), {
         autoDismiss: true,
@@ -131,29 +144,11 @@ const Setup = () => {
       });
 
       setMediaServerSettingsComplete(false);
-          localStorage.removeItem('mediaServerSettingsComplete');
     }
   };
 
-      validateLibraries();
-    } else {
-      // Initialize from localStorage on mount
-      const storedState =
-        localStorage.getItem('mediaServerSettingsComplete') === 'true';
-      setMediaServerSettingsComplete(storedState);
-    }
-  }, [
-    settings.currentSettings.mediaServerType,
-    settings.currentSettings.initialized,
-    router,
-    currentStep,
-    toasts,
-    intl,
-  ]);
-
   const handleComplete = () => {
-    setMediaServerSettingsComplete(true);
+    validateLibraries();
-    localStorage.setItem('mediaServerSettingsComplete', 'true');
   };
 
   if (settings.currentSettings.initialized) return <></>;